Do not store cockpit_redirect when remembering tabs on dashboard #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@c3c47b7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cockpit worker is running, the redirection to the proxy URL is being handled by the dashboard controller. The reason behind this is unknown, but I found out that the
handle_remember_tabis being called with thecockpit_redirectaction. This causes the session to store this action for the next time the user clicks on the cloud intel in the menu.@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @mzazrivec
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1585569