Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name and extra semicolon in VMDB summary view #4677

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Fix variable name and extra semicolon in VMDB summary view #4677

merged 1 commit into from
Oct 1, 2018

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Sep 19, 2018 •
edited
Loading

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1623091

Wrong variable name was assigned to the component props, that is why it was not showing the summary screen.

Also the JS errors were caused by extra semicolon in props JSON definition.

@Hyperkid123
Copy link
Contributor Author

@miq-bot assign @martinpovolny
cc @h-kataria

@Hyperkid123
Copy link
Contributor Author

@martinpovolny please check if the summary is displaying correct data.

@Hyperkid123
Copy link
Contributor Author

@miq-bot add-label bug

@miq-bot miq-bot added the bug label Sep 19, 2018
@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit Hyperkid123@ba233f8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny merged commit 37cc397 into ManageIQ:master Oct 1, 2018
@martinpovolny martinpovolny added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 1, 2018
@Hyperkid123 Hyperkid123 deleted the fix-vmdb-summary-view branch October 1, 2018 08:40
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@martinpovolny @simaishi
Merge pull request #4677 from Hyperkid123/fix-vmdb-summary-view
69aeea0 
Fix variable name and extra semicolon in VMDB summary view

(cherry picked from commit 37cc397)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623091
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 69aeea01edacc5fd8d71420bff45bf48cefdee50
Author: Martin Povolny <[email protected]>
Date:   Mon Oct 1 10:14:24 2018 +0200

    Merge pull request #4677 from Hyperkid123/fix-vmdb-summary-view
    
    Fix variable name and extra semicolon in VMDB summary view
    
    (cherry picked from commit 37cc3970fa35ecb8f6d87507d552a2b96390e20b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug hammer/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hyperkid123 @miq-bot @simaishi @martinpovolny @mzazrivec