Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed saving of custom button role visibility #4956

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fixed saving of custom button role visibility #4956

merged 1 commit into from
Nov 22, 2018

Conversation

h-kataria
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650090

before:
before

after:
after

@lgalis please review/test

@h-kataria h-kataria requested a review from lgalis November 21, 2018 17:35
@mzazrivec mzazrivec assigned mzazrivec and unassigned dclarizio Nov 22, 2018
@mzazrivec mzazrivec added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 22, 2018
@mzazrivec mzazrivec merged commit 034d3ed into ManageIQ:master Nov 22, 2018
simaishi pushed a commit that referenced this pull request Nov 26, 2018
@mzazrivec @simaishi
Merge pull request #4956 from h-kataria/custom_button_role_visibility…
f400154 
…_fix

Fixed saving of custom button role visibility

(cherry picked from commit 034d3ed)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650090
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f400154fd19e6c5dd99891ef1cf310906fd32f24
Author: Milan Zázrivec <[email protected]>
Date:   Thu Nov 22 09:07:12 2018 +0100

    Merge pull request #4956 from h-kataria/custom_button_role_visibility_fix
    
    Fixed saving of custom button role visibility
    
    (cherry picked from commit 034d3ede791095a25fa1bd6a2196ab2fb59649ab)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650090

@h-kataria h-kataria deleted the custom_button_role_visibility_fix branch April 9, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalis lgalis lgalis approved these changes

Assignees

@mzazrivec mzazrivec

Labels
automation/automate blocker bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @simaishi @lgalis @dclarizio @mzazrivec