Add missing styling to user input filter modal #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_reviewer @h-kataria |
|
@miq-bot add_label formatting/styling, bug |
mzazrivec
reviewed
Jan 30, 2019
| @@ -23,19 +23,25 @@ | |||
| options_for_select([_("<Choose>")] + MiqExpression.get_entry_details(@edit[:qs_tokens][token][:tag]).sort_by { |desc, _name| desc.downcase }, | |||
| nil), | |||
| :multiple => false, | |||
| :class => "widthed", | |||
| :class => "selectpicker", | |||
There was a problem hiding this comment.
The hash rockets should be aligned with the rest (same for other changes like this in this PR).
|
Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/0b47291582192bf8a3202192e4d461eca0824dd0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
h-kataria
approved these changes
Jan 30, 2019
|
@epwinchell Can this be |
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Feb 5, 2019
Add missing styling to user input filter modal (cherry picked from commit 6c700cc) https://bugzilla.redhat.com/show_bug.cgi?id=1672704
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing bootstrap select styling from the user input filter modal
https://bugzilla.redhat.com/show_bug.cgi?id=1670458
Before
After
