Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delimiter for Request ID #5872

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

romanblanco
Copy link
Member

If used, Request ID is copied to be used to search, in such case, we don't want to include delimiters

Steps for Testing/QA

  1. Order a service
  2. Go to Requests

If used, Request ID is copied to be used to search, in such case, we don't want to include delimiters
@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2019

Checked commit romanblanco@970d628 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny self-assigned this Jul 26, 2019
@martinpovolny martinpovolny merged commit 953e336 into ManageIQ:master Jul 26, 2019
@martinpovolny martinpovolny added this to the Sprint 117 Ending Aug 5, 2019 milestone Jul 26, 2019
@romanblanco romanblanco deleted the request_id_delimiter branch July 26, 2019 09:18
simaishi pushed a commit that referenced this pull request Jul 26, 2019
Remove delimiter for Request ID

(cherry picked from commit 953e336)
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 179632ae0dd0004b873df0291231ff91f7bc4ca3
Author: Martin Povolny <[email protected]>
Date:   Fri Jul 26 09:27:56 2019 +0200

    Merge pull request #5872 from romanblanco/request_id_delimiter
    
    Remove delimiter for Request ID
    
    (cherry picked from commit 953e336bbe4f8677fc48d54c6f624f5a22706ec5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants