Allow any EMS to create cloud volume #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to OpenStack where `CloudVolume` is part of the OpenStack cloud manager, Amazon provides a separate EMS for block storage management. This is not based on `EmsCloud`. Therefore, when only Amazon provider is available, the button for creating a new cloud volume is disabled. This patch checks all `CloudVolume`s that are defined by any `ExtManagementSystem` and enables the button as soon as any of them supports volume creation. New requirement has been described in the updated spec that fails with the current version. Applying this patch all tests pass.
|
Checked commit gberginc@0cd62ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to OpenStack where
CloudVolumeis part of the OpenStack cloudmanager, Amazon provides a separate EMS for block storage management.
This is not based on
EmsCloud. Therefore, when only Amazon provider isavailable, the button for creating a new cloud volume is disabled.
This patch checks all
CloudVolumes that are defined by anyExtManagementSystemand enables the button as soon as any of themsupports volume creation.
New requirement has been described in the updated spec that fails with
the current version. Applying this patch all tests pass.
@miq-bot add_label storage,enhancement