Fix multilabel tables for Container entities #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label compute/containers, bug |
|
@simon3z @martinpovolny Please review |
|
@zakiva any test that we can add here? |
zakiva
force-pushed
the
fix_multilabel_tables
branch
from
3473f68 to
898ffe3
Compare
|
Checked commit zakiva@898ffe3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@zakiva nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1423450
Issue introduced in #274. The data in multilabel tables is not displayed, we should use
TextualMultilabelinstead ofTextualGroup.Before:
After:
