Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hostname error #9078

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix hostname error #9078

merged 1 commit into from
Feb 20, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 13, 2024

this fixes an issue with:

Reproducer:

Not sure if this needs to handle hostname and/or linux_host_name or the name was wrong.

It calls URL http://localhost:3000/vm_infra/prov_field_changed/new

Data undefined method `[]=' for nil:NilClass [vm_infra/prov_field_changed]

manageiq-ui-classic/app/controllers/application_controller/miq_request_methods.rb:42:in `prov_field_changed'

It also causes another issue on other pages:

all_dialogs[:customize][:fields][:hostname][:read_only] = true
                                           ^^^^^^^^^^^^^^

manageiq-ui-classic/app/controllers/application_controller/miq_request_methods.rb:42:in `prov_field_changed'

@kbrock kbrock added the bug label Feb 13, 2024
@kbrock kbrock requested a review from a team as a code owner February 13, 2024 02:52
@Fryguy
Copy link
Member

Fryguy commented Feb 13, 2024

@GilbertCherrie Please review.

@Fryguy Fryguy removed their assignment Feb 13, 2024
@GilbertCherrie
Copy link
Member

@kbrock The provision instance page uses hostname (#9063). It seems that the clone page uses linux_host_name. Would you be able to change this pr so that it can handle both?

URL http://localhost:3000/vm_infra/prov_field_changed/new

```
Data undefined method `[]=' for nil:NilClass [vm_infra/prov_field_changed]
```

manageiq-ui-classic/app/controllers/application_controller/miq_request_methods.rb:42:in `prov_field_changed'

```
all_dialogs[:customize][:fields][:hostname][:read_only] = true
                                           ^^^^^^^^^^^^^^
```
manageiq-ui-classic/app/controllers/application_controller/miq_request_methods.rb:42:in `prov_field_changed'
@miq-bot
Copy link
Member

miq-bot commented Feb 20, 2024

Checked commit kbrock@ff79958 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@kbrock
Copy link
Member Author

kbrock commented Feb 20, 2024

update:

  • supporting hostname and linux_host_name parameters

tested with clone_vm

@GilbertCherrie is this what you had in mind?

@GilbertCherrie
Copy link
Member

Yeah this looks good.

@GilbertCherrie GilbertCherrie merged commit e8e1887 into ManageIQ:master Feb 20, 2024
15 checks passed
@kbrock kbrock deleted the button_hostname branch February 23, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants