[EUWE] Fix IE11 VMRC connectivity #15220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@himdel can you please review. |
himdel
reviewed
May 24, 2017
| @@ -328,13 +322,14 @@ | |||
| } | |||
| console.debug("VMRC: is ready to start."); | |||
|
|
|||
| if ($.browser.msie) { | |||
| isIE = #{is_browser_ie?}; | |||
|
Except for the global var, LGTM 👍 Ah, and you may also want to remove the |
|
@himdel Fixed global var reference (had to be lack of caffeine..) and updated bower.json as well. I referenced the upstream PR in the commit message for historical context. |
|
Checked commits bmclaughlin/manageiq@bab293d~...82dd974 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified VMRC connectivity in IE10, IE11, Edge, Chrome and Firefox during unit testing (Linux & Windows).
@miq-bot add_labels ui, bug, blocker
https://bugzilla.redhat.com/show_bug.cgi?id=1414869