Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate - Retirement - Remove miq_provision and/or tag code #6290

Merged
merged 1 commit into from
Jan 22, 2016

Conversation

tinaafitz
Copy link
Member

Changed cloud/infra remove_from_provider methods.

https://bugzilla.redhat.com/show_bug.cgi?id=1300559

@tinaafitz tinaafitz changed the title Automate - Retirement - Remove miq_provision and/or tag code [WIP] Automate - Retirement - Remove miq_provision and/or tag code Jan 21, 2016
@tinaafitz tinaafitz changed the title [WIP] Automate - Retirement - Remove miq_provision and/or tag code Automate - Retirement - Remove miq_provision and/or tag code Jan 21, 2016
@tinaafitz
Copy link
Member Author

@gmcculloug
Please review.

@mkanoor
Copy link
Contributor

mkanoor commented Jan 21, 2016

@tinaafitz
Has this gone thru a roundtrip from the DB?

@miq-bot
Copy link
Member

miq-bot commented Jan 21, 2016

Checked commit tinaafitz@3e1b9e2 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0
2 files checked, 0 offenses detected
Everything looks good. 🍪

@tinaafitz
Copy link
Member Author

@mkanoor
I edited through the UI, then exported it, so it should be good.

gmcculloug added a commit that referenced this pull request Jan 22, 2016
Automate - Retirement - Remove miq_provision and/or tag code
@gmcculloug gmcculloug merged commit 7211589 into ManageIQ:master Jan 22, 2016
@gmcculloug gmcculloug added this to the Sprint 35 Ending Jan 25, 2016 milestone Jan 22, 2016
@tinaafitz tinaafitz deleted the retire_tag_fix branch January 22, 2016 17:28
durandom pushed a commit to durandom/manageiq that referenced this pull request Feb 29, 2016
Automate - Retirement - Remove miq_provision and tag code

from the cloud/infra remove_from_provider methods.

https://bugzilla.redhat.com/show_bug.cgi?id=1301149

Original:
https://bugzilla.redhat.com/show_bug.cgi?id=1300559
ManageIQ#6290

Clean cherry-pick.

See merge request !745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants