Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animations with zero runtime length to give a useful error instead of a broken pipe #3491

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Fix animations with zero runtime length to give a useful error instead of a broken pipe #3491

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a980b90
Fix animation group not erroring when instantiated with an empty list
MrDiver Dec 5, 2023
3d8f269
Move error messages into Animation.begin()
MrDiver Dec 9, 2023
3c5bd82
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2023
5fd208c
Added tests
MrDiver Dec 9, 2023
de8a55d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2023
fdc0ccd
Update manim/animation/animation.py
MrDiver Dec 10, 2023
cfdc8c5
Update manim/animation/composition.py
MrDiver Dec 10, 2023
d932b57
Merge branch 'main' into animation_group_empty
MrDiver Dec 10, 2023
d4621e4
Update manim/animation/animation.py
MrDiver Dec 10, 2023
003952b
Merge branch 'main' into animation_group_empty
MrDiver Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions manim/animation/composition.py
View file
Open in desktop
MrDiver marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def __init__(
lag_ratio: float = 0,
**kwargs,
) -> None:
if len(animations) == 0:
raise ValueError("AnimationGroup must have at least one animation")
self.animations = [prepare_animation(anim) for anim in animations]
self.rate_func = rate_func
self.group = group
Expand Down
Loading