Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a wrong type mark in a function head. #3902

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

fogsong233
Copy link
Contributor

Overview: What does this pull request change?

When i am reading the source code, i notice a wrong type setting in the function, then i fix it.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

i'm sure that there are lots of function without types, i hope it can be better.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Do you mind changing it from list[Mobject] into Sequence[Mobject]? That way it works with tuples as well :)

@fogsong233
Copy link
Contributor Author

Nice catch! Do you mind changing it from list[Mobject] into Sequence[Mobject]? That way it works with tuples as well :)

ok, you are thoughtful. i have changed it : )

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :)

@JasonGrace2282 JasonGrace2282 merged commit aa660c7 into ManimCommunity:main Aug 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants