-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove need for extern crate
in 2018 Edition crates
#150
Comments
On Sat, Dec 08, 2018 at 08:56:33PM -0800, Sunjay Varma wrote:
The Rust 2018 edition removes the need for `extern crate`, but I still find myself needing to add it to my test files in order to get `compiletest` working. Is there a way to remove those?
Hmmm, I haven't looked at that. Do you have a link to your project/code? Have
you looked at what rustc/compiletest does/have done? I wonder if you have the
same or similar issue.
…
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#150
|
Hi, sorry for the delay. My code is finally public and I can share it now. If you remove the extern crate lines from my compile tests, the tests fail to compile. Project is here: https://github.com/sunjay/component_group |
Here is how I set up 2018 edition ui tests in tt-call: #[test]
fn ui() {
let mut config = compiletest::Config {
mode: compiletest::common::Mode::Ui,
src_base: std::path::PathBuf::from("cases"),
target_rustcflags: Some(String::from(
"\
--edition=2018 \
-Z unstable-options \
--extern tt_call \
",
)),
..Default::default()
};
config.link_deps();
config.clean_rmeta();
compiletest::run_tests(&config);
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Rust 2018 edition removes the need for
extern crate
, but I still find myself needing to add it to my test files in order to getcompiletest
working. Is there a way to remove those?The text was updated successfully, but these errors were encountered: