WIP Update from upstream #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Munksgaard
force-pushed
the
update-from-upstream
branch
5 times, most recently
from
b6a3936 to
4122778
Compare
phansch
reviewed
Nov 15, 2019
| // rustdoc will test the output of the `--test` option | ||
| pub check_test_line_numbers_match: bool, | ||
| // The test must be compiled and run successfully. Only used in UI tests for | ||
| // now. | ||
| pub run_pass: bool, |
There was a problem hiding this comment.
The removal of the two headers has potential to silently change the result of tests. Do you think it makes sense to deprecate them before removing them?
There was a problem hiding this comment.
That's a good point. I wonder why they were removed in the original compiletest.
There was a problem hiding this comment.
IIRC, they were just renamed, not removed. I'm not sure right now which are the correct replacements for each.
There was a problem hiding this comment.
fwiw, I think it would also be fine to add a changelog that explains the changes =)
Munksgaard
force-pushed
the
update-from-upstream
branch
from
4122778 to
6780f4a
Compare
Munksgaard
force-pushed
the
update-from-upstream
branch
from
6780f4a to
d1fe0f1
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is more than to update from upstream, I also want to explore the possibility of using this library as a replacement for the compiletest binary in Rust. It would be nice if there was only one codebase, and it could be used both for testing Rust itself, and for testing external Rust libraries.
Inspired by #165 (comment)