Merge pull request #23 from Mapudo/MAP-2890

MAP-2890 As a Developer, I have detailed information about running Ak…

CHANGELOG.md

@@ -4,6 +4,10 @@ All Notable changes to `mapudo/guzzle-bundle` will be documented in this file.
 
 Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) principles.
 
+## [2.2.1] - 2018-12-07
+### Changed
+- Fix `duration` in `LogMiddleware` parameter due to it needs to be passed by reference to a method to work properly
+
 ## [2.2.0] - 2018-11-29
 ### Changed
 - Add `duration` property to be logged in `LogMiddleware` to keep track of the request duration

src/Middleware/LogMiddleware.php

@@ -63,13 +63,16 @@ public function log(): \Closure
                 };
 
                 return $handler($request, $options)->then(
-                    function (ResponseInterface $response) use ($logger, $request, $formatter, $duration) {
+                    // `$duration` is passed by reference because at the time when the callback
+                    // is registered the variable `$duration` is `null`.
+                    // The stats callback is executed before the custom promise callbacks are executed.
+                    function (ResponseInterface $response) use ($logger, $request, $formatter, &$duration) {
                         $message = $formatter->format($request, $response);
                         $logger->info($message, $this->buildContext($request, $response, $duration));
 
                         return $response;
                     },
-                    function ($reason) use ($logger, $request, $formatter, $duration) {
+                    function ($reason) use ($logger, $request, $formatter, &$duration) {
                         $response = $reason instanceof RequestException ? $reason->getResponse() : null;
                         $message  = $formatter->format($request, $response, $reason);
                         $logger->error($message, $this->buildContext($request, $response, $duration));