Extract some of #3360 fixes to 10.6.x #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Sep 13, 2024
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes. (Excludes previous parts MariaDB#3485 and MariaDB#3493)
3 tasks
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Sep 14, 2024
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes. (Excludes previous parts MariaDB#3485 and MariaDB#3493)
3 tasks
ParadoxV5
force-pushed
the
10.6-my_snprintf
branch
from
9221411
to
41a47de
Compare
ParadoxV5
added a commit
to ParadoxV5/MariaDB-server
that referenced
this pull request
Nov 15, 2024
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes. (Excludes previous parts MariaDB#3485 and MariaDB#3493)
That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes (excludes MariaDB#3485).
ParadoxV5
force-pushed
the
10.6-my_snprintf
branch
from
41a47de
to
94923d7
Compare
grooverdan
approved these changes
Nov 18, 2024
ParadoxV5
added a commit
that referenced
this pull request
Nov 21, 2024
…as mistakenly applied on an earlier branch It is `ulint` on 10.6 and `uint32_t` on 10.11+, but I included its format specifier change in 10.6 (MDEV-35430, merged #3493) rather than 10.11+. This commit reverts that change so 10.11 can reapply it.
4 tasks
ParadoxV5
added a commit
that referenced
this pull request
Nov 21, 2024
…as mistakenly applied on an earlier branch It is `ulint` on 10.6 and `uint32_t` on 10.11+, but I included its format specifier change in 10.6 (MDEV-35430, merged #3493) rather than 10.11. This commit reverts that change so 10.11 can reapply it.
4 tasks
grooverdan
pushed a commit
that referenced
this pull request
Nov 25, 2024
…as mistakenly applied on an earlier branch It is `ulint` on 10.6 and `uint32_t` on 10.11+, but I included its format specifier change in 10.6 (MDEV-35430, merged #3493) rather than 10.11. This commit reverts that change so 10.11 can reapply it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-21978While this code originates from my GSoC project, this publication (i.e., commit and PR descriptions) isn’t.
Description
#3360 uncovered countless potential minor security vulnerabilities on
my_snprintfuses.This commit ports a squashed subset of their fixes according to the bug-fixing process to 10.6, covering cases that weren’t applicable for 10.5 (#3485).
(My GSoC mentor said that they aren’t much of a problem and I can open a PR normally.)
Similar to #3485, I haven’t changed
size_ts from%dto%uand haven’t searched issues obsolete in 11.6.Release Notes
Nothing either?How can this PR be tested?
I’m not certain how we could catch these human errors besides testing #3360 (MDEV-21978) and syncing this PR with it.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check