Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-34179 Disable purge for LOAD DATA INFILE into empty table #3628

Open
wants to merge 1 commit into
base: 11.6
Choose a base branch
from

Conversation

Thirunarayanan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-34179

Description

  • While doing LOAD DATA INFILE into the empty table, write only TRX_UNDO_EMPTY undo log. This can be achieved by having separate flag in trx_mod_table_time_t for writing the TRX_UNDO_EMPTY record

row_ins_clust_index_entry_low(): Start the bulk insert for load command and don't create bulk buffer.

trx_undo_report_row_operation(): Enable the write empty undo log for the first time.

How can this PR be tested?

need to come up with test case to prove undo log wasn't written for every insert
in load data statement

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

- While doing LOAD DATA INFILE into the empty table, write only
TRX_UNDO_EMPTY undo log. This can be achieved by having
separate flag in trx_mod_table_time_t for writing the TRX_UNDO_EMPTY
record

row_ins_clust_index_entry_low(): Start the bulk insert for load
command and don't create bulk buffer.

trx_undo_report_row_operation(): Enable the write empty undo log
for the first time.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@grooverdan
Copy link
Member

dyslexia? Me too - the MDEV number is MDEV-34719

@Thirunarayanan
Copy link
Member Author

dyslexia? Me too - the MDEV number is MDEV-34719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants