-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDEV-35394 Innochecksum misinterprets freed undo pages #3636
Open
Thirunarayanan
wants to merge
1
commit into
10.6
Choose a base branch
from
10.6-MDEV-35394
base: 10.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thirunarayanan
force-pushed
the
10.6-MDEV-35394
branch
2 times, most recently
from
November 18, 2024 08:49
29e04c6
to
d93ade0
Compare
dr-m
reviewed
Nov 20, 2024
Thirunarayanan
force-pushed
the
10.6-MDEV-35394
branch
3 times, most recently
from
November 21, 2024 09:34
532eed6
to
e95959e
Compare
dr-m
reviewed
Nov 21, 2024
Thirunarayanan
force-pushed
the
10.6-MDEV-35394
branch
from
November 22, 2024 05:40
e95959e
to
e94fe20
Compare
dr-m
reviewed
Nov 22, 2024
Thirunarayanan
force-pushed
the
10.6-MDEV-35394
branch
3 times, most recently
from
November 25, 2024 07:00
3390619
to
ff36b28
Compare
- Innochecksum misinterprets the freed pages as active one. This leads the user to think there are too many valid pages exist. - To avoid this confusion, innochecksum introduced one more option --skip-freed-pages and -r to avoid the freed pages while dumping or printing the summary of the tablespace. - Innochecksum can safely assume the page is freed if the respective extent doesn't belong to a segment and marked as freed in XDES_BITMAP in extent descriptor page. - Innochecksum shouldn't assume that zero-filled page as extent descriptor page.
Thirunarayanan
force-pushed
the
10.6-MDEV-35394
branch
from
November 26, 2024 06:33
ff36b28
to
0be600a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Innochecksum misinterprets the freed undo log pages as active one. This leads the user to think there are too many undo log pages exist.
Innochecksum can safely assume the undo log page is freed if the respective extent doesn't belong to a segment and marked as freed in XDES_BITMAP in extent descriptor page.
Innochecksum shouldn't assume that zero-filled page as extent descriptor page.
How can this PR be tested?
./mtr innodb.innochecksum_undo_page
Basing the PR against the correct MariaDB version
main
branch.PR quality check