Implement Conditional Rendering of Download Test Result Button #7417
+81
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases to assign_all, unassign_all, and unassign_single methods
Pull Request Test Coverage Report for Build 13202298251Details
💛 - Coveralls |
david-yz-liu
reviewed
Feb 4, 2025
There was a problem hiding this comment.
@Raine-Yang-UofT nice work! The change is good, but please also add front-end tests for the changes. This is a good chance to learn how to use react-testing-library to test front-end code. 😄
david-yz-liu
reviewed
Feb 7, 2025
| @@ -629,6 +629,7 @@ def summary_json(user) | |||
| criteriaColumns: criteria_columns, | |||
| numAssigned: self.get_num_assigned(user.instructor? ? nil : user.id), | |||
| numMarked: self.get_num_marked(user.instructor? ? nil : user.id), | |||
| enableTest: self.assignment_properties&.enable_test || false, | |||
There was a problem hiding this comment.
Oh sorry I didn't catch this earlier, but you can just use self.enable_test. If you're curious you can learn about the delegate_missing_to method.
|
|
||
| it("should render the Download Test Results button", async () => { | ||
| await waitFor(() => { | ||
| expect(screen.getByText(/download test results/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
Don't hard-code the string in these tests, and instead use I18n here to use the localized string. This mirrors what label we assign the button in the application code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Implement conditional rendering of "download test result" button in assignment summary page such that this button only appears if automated testing is enabled for the assignment.
...
Screenshots of your changes (if applicable)
"Download Test Result" not appearing for an assignment without automated testing.
"Download Test Result" appearing for an assignment with automated testing.
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)