Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python tester to allow a requirements file #580

Conversation

rickychen174
Copy link
Contributor

@rickychen174 rickychen174 commented Jan 13, 2025

Changes:

  • Change the Python autotester settings schema to include an optional field for a requirements file
  • The Python autotester setup will find the requirements file from the test files and install those packages

Testing Procedure

  • Rebuild schema and enter a Python assignment. The Python environment section will have a new field: Package requirements file
  • Add a requirements file with NumPy and add a test file which uses NumPy.
  • Save the settings and run tests
    • With the correct requirements file name provided, the NumPy test passes
    • With an incorrect requirements file name provided, the tests do not start
    • With no requirements file name provided, the NumPy test fails

@rickychen174 rickychen174 marked this pull request as ready for review January 13, 2025 16:53
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickychen174 nice work! Please also make these changes for the jupyter tester.

@donny-wong
Copy link
Contributor

@rickychen174 nice work! Please also make these changes for the jupyter tester.

@rickychen174, please also add it to the pyta tester, thank you.

@rickychen174
Copy link
Contributor Author

@rickychen174 nice work! Please also make these changes for the jupyter tester.

I applied the changes for the jupyter and pyta testers.

Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @rickychen174!

@david-yz-liu david-yz-liu merged commit 5e276a5 into MarkUsProject:master Jan 16, 2025
7 checks passed
@donny-wong donny-wong added this to the v2.6.1 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants