use DotDict everywhere #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
CamundaLibrary/CamundaLibrary.py
Outdated
| @@ -92,7 +93,7 @@ class CamundaLibrary: | |||
| EMPTY_STRING = "" | |||
| KNOWN_TOPICS: Dict[str, Dict[str, Any]] = {} | |||
| FETCH_RESPONSE: LockedExternalTaskDto = {} | |||
| DEFAULT_LOCK_DURATION = None | |||
| DEFAULT_LOCK_DURATION: int = None | |||
There was a problem hiding this comment.
Incompatible attribute type: Attribute DEFAULT_LOCK_DURATION declared in class CamundaLibrary has type int but is used as type None.
(at-me in a reply with help or ignore)
|
Not sure about this pull request. It was already hard enough to handle conversion from Java objects and JSON in to python DTO and collection types. Replacing python dicts with DotDict does not work everywhere. When a JSON variable contains other nested dictionaries then I do not get them converted. Looks like I need to decide between consistancy (old fashioned Dicts everywhere) or convenience (DotDict in most places, but old fashioned dicts in some other). |
|
won't fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.