Fix reprap graphic anti-corruption values

https://marlinfw.org/docs/basics/troubleshooting.html
Marlin-DE200 · Mar 1, 2024 · 1be9095 · 1be9095
1 parent dbc9afe
commit 1be9095
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 38 deletions.
diff --git a/Marlin/Configuration.h b/Marlin/Configuration.h
@@ -3105,6 +3105,10 @@
 //
 #if ENABLED(DE200_SCREEN_STD)
   #define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
+  // Prevent minor graphic corruption
+  #define ST7920_DELAY_1 DELAY_NS(200) // After CLK LOW
+  #define ST7920_DELAY_2 DELAY_NS(400) // After DAT
+  #define ST7920_DELAY_3 DELAY_NS(200) // After CLK HIGH
 #endif
 
 //

diff --git a/Marlin/src/pins/ramps/pins_MKS_BASE_15_DAGOMA.h b/Marlin/src/pins/ramps/pins_MKS_BASE_15_DAGOMA.h
@@ -51,41 +51,3 @@
 #undef FIL_RUNOUT2_PIN
 #define FIL_RUNOUT_PIN 19
 #define FIL_RUNOUT2_PIN 14
-
-// From https://github.com/MarlinFirmware/Marlin/issues/12003
-// #if IS_U8GLIB_ST7920
-  // #define BOARD_ST7920_DELAY_1                 0
-  // #define BOARD_ST7920_DELAY_2               250 or 400
-  // #define BOARD_ST7920_DELAY_3                 0
-// #endif
-
-// From https://github.com/MarlinFirmware/Marlin/issues/12003 for long cables
-// #define ST7920_DELAY_1 DELAY_NS (0)
-// #define ST7920_DELAY_2 DELAY_NS (250)
-// #define ST7920_DELAY_3 DELAY_NS (250)
-
-
-// From Github PRs for other boards
-// Alter timing for graphical display
-#if HAS_MARLINUI_U8GLIB
-  #ifndef BOARD_ST7920_DELAY_1
-    //#define BOARD_ST7920_DELAY_1    DELAY_NS(96)
-    // #define BOARD_ST7920_DELAY_1   DELAY_NS(120)
-    // From https://marlinfw.org/docs/basics/troubleshooting.html
-    #define BOARD_ST7920_DELAY_1 DELAY_NS(200) // After CLK LOW
-  #endif
-  #ifndef BOARD_ST7920_DELAY_2
-    //#define BOARD_ST7920_DELAY_2    DELAY_NS(48)
-    // #define BOARD_ST7920_DELAY_2    DELAY_NS(80)
-    // From https://marlinfw.org/docs/basics/troubleshooting.html
-    #define BOARD_ST7920_DELAY_2 DELAY_NS(400) // After DAT
-  #endif
-  #ifndef BOARD_ST7920_DELAY_3
-    //#define BOARD_ST7920_DELAY_3   DELAY_NS(600)
-    // #define BOARD_ST7920_DELAY_3   DELAY_NS(580)
-    // From reprap site for RRD_FGDC
-    //#define BOARD_ST7920_DELAY_3   DELAY_NS(63)
-    // From https://marlinfw.org/docs/basics/troubleshooting.html
-    #define BOARD_ST7920_DELAY_3 DELAY_NS(200) // After CLK HIGH
-  #endif
-#endif