Skip to content

Commit

Permalink
Removed the DISABLE from HOST_KEEPALIVE_FEATURE option
Browse files Browse the repository at this point in the history
  • Loading branch information
jbrazio committed May 11, 2016
1 parent a454a88 commit ac7f634
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
6 changes: 3 additions & 3 deletions Marlin/Conditionals.h
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,10 @@
#endif

/**
* Avoid double-negatives for enabling features
* Host keep alive
*/
#if DISABLED(DISABLE_HOST_KEEPALIVE)
#define HOST_KEEPALIVE_FEATURE
#ifndef HOST_KEEPALIVE_INTERVAL
#define HOST_KEEPALIVE_INTERVAL 2
#endif

/**
Expand Down
8 changes: 3 additions & 5 deletions Marlin/Configuration.h
Original file line number Diff line number Diff line change
Expand Up @@ -733,13 +733,11 @@ const bool Z_MIN_PROBE_ENDSTOP_INVERTING = false; // set to true to invert the l
//
// Host Keepalive
//
// By default Marlin will send a busy status message to the host
// When enabled Marlin will send a busy status message to the host
// every couple of seconds when it can't accept commands.
//
//#define DISABLE_HOST_KEEPALIVE // Enable this option if your host doesn't like keepalive messages.
#if DISABLED(DISABLE_HOST_KEEPALIVE)
#define DEFAULT_KEEPALIVE_INTERVAL 2 // Number of seconds between "busy" messages. Set with M113.
#endif
#define HOST_KEEPALIVE_FEATURE // Disable this if your host doesn't like keepalive messages
#define HOST_KEEPALIVE_INTERVAL 2 // Number of seconds between "busy" messages. Set with M113.

//
// M100 Free Memory Watcher
Expand Down
2 changes: 1 addition & 1 deletion Marlin/Marlin_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ static bool send_ok[BUFSIZE];

static MarlinBusyState busy_state = NOT_BUSY;
static millis_t next_busy_signal_ms = 0;
uint8_t host_keepalive_interval = DEFAULT_KEEPALIVE_INTERVAL;
uint8_t host_keepalive_interval = HOST_KEEPALIVE_INTERVAL;
#define KEEPALIVE_STATE(n) do{ busy_state = n; }while(0)
#else
#define host_keepalive() ;
Expand Down

0 comments on commit ac7f634

Please sign in to comment.