Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] (SD_FINISHED_RELEASECOMMAND issue in 2.0.5.3) #17401

Closed
BaBBa71 opened this issue Apr 4, 2020 · 7 comments
Closed

[BUG] (SD_FINISHED_RELEASECOMMAND issue in 2.0.5.3) #17401

BaBBa71 opened this issue Apr 4, 2020 · 7 comments

Comments

@BaBBa71
Copy link
Contributor

BaBBa71 commented Apr 4, 2020

Bug Description

In my custom Delta printer with firmware 2.0.5.3 an unknown "disable all stepper" occur even I have set only to disable E in Configuration_adv.h with this line:

 #define SD_FINISHED_STEPPERRELEASE true         
 #define SD_FINISHED_RELEASECOMMAND "M84 E" 

even if I have defined also this line:

#define DEFAULT_STEPPER_DEACTIVE_TIME 60
#define DISABLE_INACTIVE_X false
#define DISABLE_INACTIVE_Y false
#define DISABLE_INACTIVE_Z false 
#define DISABLE_INACTIVE_E true

This occours only when I print from SD CARD. Same model (same GCODE with no disable command obviously at the end !!!) printed by serial USB connection don't disable the steppers.

I tried to change the value in #define SD_FINISHED_RELEASECOMMAND with a simple sound like "M300 S4400 P3000" but at the end of SD printing, after last command in gcode (homing with G28) no sound is played and the delta effector fall down.

My Configurations

config.zip

Steps to Reproduce

  1. In a delta printer with graphical display 12864 and SD support enabled, modify this line in Configuration_adv.h with this:

1st example config

  #define SD_FINISHED_STEPPERRELEASE true         
  #define SD_FINISHED_RELEASECOMMAND "M84 E" 

or 2nd example config

  #define SD_FINISHED_STEPPERRELEASE true         
  #define SD_FINISHED_RELEASECOMMAND "M300 S4400 P3000"
  1. Select "Print from media" and select a simple gcode file with no disable steppers command (M18 or M84) at the end of printing code.
  2. Start print.
  3. Wait the end of print
  4. Observe the status of XYZ steppers.

Expected behavior:
No X Y Z steppers disabled at the end of print in both example. For the second configuration line a 3 second sound should be heard.

Actual behavior:
All steppers disabled in first conf.
All steppers disabled and no sound reproduced in second config.

Additional Information

My previous marlin firmware works perfectly with this parameters but have some issue (during printing) with usability of display,
Actually I made a workaround by setting "false" in SD_FINISHED_STEPPERRELEASE but I want to disable only the extruders steppers.

@studiodyne
Copy link
Contributor

studiodyne commented Apr 5, 2020

I think all issues have the same source
17393
On 2020 03 19 , no bug , and after this date , sd printing freeze on any command in the buffer sent by lcd
Please can you help me to confirm this , by trying all i explain in my issue page

Thks

@BaBBa71
Copy link
Contributor Author

BaBBa71 commented Apr 5, 2020

I think all issues have the same source
17393
On 2020 03 19 , no bug , and after this date , sd printing freeze on any command in the buffer sent by lcd
Please can you help me to confirm this , by trying all i explain in my issue page

Thks

I tried this and get same issue

@BaBBa71
Copy link
Contributor Author

BaBBa71 commented Apr 10, 2020

I think all issues have the same source
17393
On 2020 03 19 , no bug , and after this date , sd printing freeze on any command in the buffer sent by lcd
Please can you help me to confirm this , by trying all i explain in my issue page

Thks

Sorry but this error does not have the same source. I have compiled today bugfix and the issue 17393 was solved. But my issue still remain. The delta carriage falling down with:

#define SD_FINISHED_STEPPERRELEASE true
and
#define SD_FINISHED_RELEASECOMMAND "M84 E"

@thinkyhead
Copy link
Member

It seems this bug was introduced between 1.1.8 and 1.1.9. 8f26c3a#diff-93a564322f37b6240dd4384e982f9425

I'll patch it shortly.

thinkyhead added a commit that referenced this issue Apr 12, 2020
Fixes #17401 bug that was introduced in 8f26c3a
@thinkyhead
Copy link
Member

The patch is now pushed. Grab the latest bugfix-2.0.x code to confirm that it works properly.

thinkyhead added a commit that referenced this issue Apr 12, 2020
Fixes #17401 bug that was introduced in 8f26c3a
thinkyhead added a commit that referenced this issue Apr 12, 2020
Fixes #17401 bug that was introduced in 8f26c3a
@BaBBa71
Copy link
Contributor Author

BaBBa71 commented Apr 12, 2020

Wonderful. I installed the latest version and the error has been resolved. Thank you very much! @thinkyhead ... Marlin is the best 3D printer firmware ever!

thinkyhead added a commit to studiodyne/Marlin that referenced this issue Apr 12, 2020
ghost pushed a commit to bfhobbes/Marlin that referenced this issue Apr 15, 2020
mathom pushed a commit to mathom/Marlin that referenced this issue Apr 17, 2020
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this issue Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this issue Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this issue Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants