Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis tests may not reflect real world #3468

Closed
jbrazio opened this issue Apr 11, 2016 · 6 comments
Closed

Travis tests may not reflect real world #3468

jbrazio opened this issue Apr 11, 2016 · 6 comments
Labels
T: Development Makefiles, PlatformIO, Python scripts, etc.

Comments

@jbrazio
Copy link
Contributor

jbrazio commented Apr 11, 2016

I see that Travis copies some kind of custom Arduino-core before compiling the source code, does this really reflect a real world case ? I take myself as an example, when I compile I use the stock Arduino-core I never use the custom one being shipped with Marlin, I can't imagine anyone doing the same thing as Travis is doing to compile Marlin.

This brings me to a question, why are we shipping a custom Arduino-core ?

@thinkyhead
Copy link
Member

It is an oddity. For my part, I only rely on Travis CI to catch my typos and make sure the code actually compiles. Apart from that, it's not used for any heavy diagnosis. But maybe it could be.

@thinkyhead thinkyhead added the T: Development Makefiles, PlatformIO, Python scripts, etc. label Apr 12, 2016
@jbrazio
Copy link
Contributor Author

jbrazio commented Apr 14, 2016

@thinkyhead but do you know why we use a custom core ? I would start by removing this custom core from the Travis build as only this action will bring us closer to the real world test condition.

@thinkyhead
Copy link
Member

I don't know the reasons why there is a custom Arduino-core, unless it is for some historical reason. We could look at the early commits where it was being worked on more.

@thinkyhead
Copy link
Member

Note that these may not be "custom" cores that are included with Marlin. They may only be included as "the cores that Marlin is known to support" and may actually be identical to their origins. But we would have to look and see if they are in fact unaltered.

@jbrazio
Copy link
Contributor Author

jbrazio commented May 10, 2016

Closes with merge of #3715

@jbrazio jbrazio closed this as completed May 10, 2016
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Development Makefiles, PlatformIO, Python scripts, etc.
Projects
None yet
Development

No branches or pull requests

2 participants