Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the buildroot #3715

Merged
merged 1 commit into from
May 15, 2016
Merged

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented May 10, 2016

It has to start somewhere.
It has to start sometime.
What better place than here ?
What better time than now ?

-- Guerilla Radio, Rage Against the Machine.

Let's give the step forward, this PR cleans unmaintained build methods, it also addresses #3468 by removing the unused Arduino cores. Complete change list:

  • Update Arduino core to 1.6.8
  • Removed PlatformIOAddons
  • Moved LinuxAddons to buildroot/bin
  • Removed ArduinoAddons
  • Removed duplicate license file Documentation\COPYING.md
  • Moved .astylerc to buildroot/etc
  • Updates travis for the new buildroot environment

@jbrazio
Copy link
Contributor Author

jbrazio commented May 12, 2016

I have build a list of "supported" boards which means boards that are listed in boards.h, for each board I found which are the micro-controller restrictions, required Arduino core and some miscellaneous notes.

You may see the information here: https://goo.gl/gFpujH
Remember this is a work in progress.

@thinkyhead
Copy link
Member

Will this affect users who would like to flout the Arduino 1.5.x requirement and build on Linux with an older tool-set anyway?

@jbrazio
Copy link
Contributor Author

jbrazio commented May 14, 2016

No.. actually those users will always need to comment the #error directive otherwise they will never compile with an old IDE. The good news is that people do upgrade their Arduino IDE, you'll be able to see this once I publish the results of the survey.

@thinkyhead thinkyhead merged commit 1fcc9ec into MarlinFirmware:RCBugFix May 15, 2016
@jbrazio jbrazio deleted the feature/buildroot branch May 15, 2016 22:33
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
Fixes MarlinFirmware#3715

When a long-press is triggered, the LCD inactivity timer
needs to be restarted. This is done with lcd_timeoutToStatus.start()

This also fixes situations where a long-press is triggered, and the timer
times out immediately (because it was not reset properly)

Change in memory:
Flash: +8 bytes
SRAM: 0 bytes
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
Fixes MarlinFirmware#3715

When a long-press is triggered, the LCD inactivity timer
needs to be restarted. This is done with lcd_timeoutToStatus.start()

This also fixes situations where a long-press is triggered, and the timer
times out immediately (because it was not reset properly)

Change in memory:
Flash: +8 bytes
SRAM: 0 bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants