Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC6 - "start print" does not zero print time after "stop print" command #3826

Closed
Roo123 opened this issue May 23, 2016 · 7 comments
Closed

Comments

@Roo123
Copy link

Roo123 commented May 23, 2016

RC6 firmware

Supposing you stop a print with "stop print" from LCD.

The current print time remains on the display. (Good.)

Then you start another print.

The time for this second print starts from the end time of the previous print. Without first zeroing.

Not good. ;-)

@jbrazio
Copy link
Contributor

jbrazio commented May 23, 2016

We need more information.

How do you start printing is it from the LCD or from the host ?
Do you have PRINTJOB_TIMER_AUTOSTART set ?

@jbrazio jbrazio added this to the 1.1.0 milestone May 23, 2016
@Roo123
Copy link
Author

Roo123 commented May 23, 2016

Started from SD card / LCD.

In which file is the printjob_timer_autostart variable located?

@jbrazio
Copy link
Contributor

jbrazio commented May 23, 2016

A few minutes ago a new PR fixing some issues with the print job timer was merged into RCBugfix, would you care to download the latest version and to a quick test to see if the behavior is still there ?

PRINTJOB_TIMER_AUTOSTART is in Configuration.h.

@Roo123
Copy link
Author

Roo123 commented May 23, 2016

PRINTJOB_TIMER_AUTOSTART isn't showing up when I search in configuration.h of RC6 ?

Afraid I can't jump into the Bugfix just at the moment....

@Blue-Marlin
Copy link
Contributor

In that case you don't have a current RCBugFix. (https://github.com/MarlinFirmware/Marlin/blob/RCBugFix/Marlin/Configuration.h#L772)

@jbrazio
Copy link
Contributor

jbrazio commented May 23, 2016

I've had a quick look and this is indeed a bug, we stop the SD print using a custom function and this function is not taking into account the print job timer.

  static void lcd_sdcard_stop() {
    stepper.quick_stop();
    card.sdprinting = false;
    card.closefile();
    thermalManager.autotempShutdown();
    cancel_heatup = true;
    lcd_setstatus(MSG_PRINT_ABORTED, true);
  }

@jbrazio jbrazio added Bug: Confirmed ! Needs: Patch A patch is needed to fix this and removed Bug: Potential ? labels May 23, 2016
jbrazio added a commit to jbrazio/Marlin that referenced this issue May 30, 2016
…rint counter

The LCD menu items for SD printing pause/stop have been updated to control
also the print job timer. This commit also fixes a small output bug with
M78, the failed print counter was displaying the wrong value.
thinkyhead added a commit that referenced this issue May 30, 2016
Closes #3826: SD printing will now pause and stop the print counter
@jbrazio jbrazio removed the Needs: Patch A patch is needed to fix this label May 30, 2016
@jbrazio jbrazio closed this as completed May 30, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 16, 2016
CONSULitAS pushed a commit to CONSULitAS/Marlin-K8200 that referenced this issue Aug 18, 2016
…rint counter

The LCD menu items for SD printing pause/stop have been updated to control
also the print job timer. This commit also fixes a small output bug with
M78, the failed print counter was displaying the wrong value.
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants