-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General cleanup, mostly MKS UI #19825
General cleanup, mostly MKS UI #19825
Conversation
095118d
to
72b4f4f
Compare
This header is inside the MKS LVGL repo..... It has the LVGL configs. |
72b4f4f
to
826fd6b
Compare
Must this header be added into Marlin before it can be located, or is it found automagically? |
It's in the same folder as <lvgl.h> Explaining: LVGL needs a configuration header, like Marlin. MKS forked LVGL, changed a few things, and added that header to their repo, fully configured for their UI. So, "lv_conf.h" is provided by the lvgl library, pointed by the marlin feature. This header contains macros with configs. Removing the marlin include can break anything? I don't know, we need to test, as include order is something sensible to macros.... |
Yes, I added tests for LVGL in |
ee3e2df
to
5832f98
Compare
I have an MKS Robin Nano 1.2 & 2.0 that I can flash here for testing as well. |
d9710f7
to
6223e73
Compare
It would be good. I cannot test today. Maybe later tonight. |
6223e73
to
ce70e2f
Compare
Gathering changes from #19812 that are unrelated to the new Web GUI to make that PR more simplified.
#include <lv_conf.h>
for external header.ZERO
macro where possible.