-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer heater/fan/stepper turn off if home bump on Z #20610
Defer heater/fan/stepper turn off if home bump on Z #20610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach seems reasonable and simple enough to me.
Change "heaters_off" to "final_approach"
** DO NOT ATTEMPT MERGE ** I will need to refactor this, as a previous/recent separate independent commit on exactly these code lines have "pulled the carpet out from under my feet" so to speak. In order to make that transparent, I will rebase/resolve conflicts/squish and then test and invite reviews anew. Please stand by until then. |
I found the merge pretty straightforward. If you still want to squash down to a single commit, it's easiest to use
|
That's ok like that. I'll give it a spin later today with and without enabling heaters off to be sure. Printers all busy right now. |
Ok, looking good, tested it and works fine. |
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (105 commits) [cron] Bump distribution date (2021-01-08) Fix M48 output (MarlinFirmware#20713) Improved MKS Robin support (MarlinFirmware#19333) Preheat before Power Loss Recovery homing (MarlinFirmware#20697) [cron] Bump distribution date (2021-01-07) Custom build_flags by feature (MarlinFirmware#20692) [cron] Bump distribution date (2021-01-06) Multi-Z stepper inverting (MarlinFirmware#20678) Fix Azteeg X3 macro typo (MarlinFirmware#20681) Define SANGUINOLOLU 1.1 enable pins (MarlinFirmware#20682) No BTN_ENC_EN on Anet 10 (MarlinFirmware#20684) Temperature report followup (MarlinFirmware#20687) Adjustable precision in M105 temperature report (MarlinFirmware#20602) Don't apply hotend_offset.z to Z soft endstops (MarlinFirmware#20675) Indent tool_change_prime Clarify solenoid active / magnet-on state Defer "quiet probing" till the last Z bump (MarlinFirmware#20610) Solenoid cleanups [cron] Bump distribution date (2021-01-05) Remove untranslated strings ...
In retrospect there is one issue with this PR: the probe is being tared before the heaters are turned off. I should have seen that before but I noticed it only after flashing the new firmware with the Z-offset drifting again. |
As a first step towards #20598, I have changed the logic in
motion.cpp
slightly, so that if aHOMING_BUMP_MM
for the Z-AXIS is configured, the heaters/fans/steppers will only be turned off for the slow probe approach after the bump.It also applies to the
DELAY_BEFORE_PROBING
.This allows them to stay on for a (potentially) long homing approach on Z.
If the homing bump is turned off ( = 0 ) nothing changes - things will be turned off on the first (and only) approach (could be a long approach, of course)
A second step, for a separate PR, would be to allow specifying which things to turn off instead of all