-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Filament Feature #2926
Closed
Change Filament Feature #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix status LEDs update when reinitializing the display By using the regular update function during init. Fixing #2683
dx -> dsx dy -> dsy dz -> dsz de -> dse
anything is long, we don't need float there
st_set_position takes long ```void st_set_position(const long& x, const long& y, const long& z, const long& e)```
Make the output of M105 more similar to Repetier. Make the text-print pert of M105 an extra function to make it reusable. `print_heaterstates()` Use `print_heaterstates()` in M019, M190 and M303
For some reason that I cannot determine, using a sub-function causes the Tune sub-menu to act strangely, yet replacing the function call with its code content works perfectly.
//100k 0603 SMD Vishay NTCS0603E3104FXT (4.7k pullup) (calibrated for Makibox hot bed) Caveat Emptor —- I’m not sure that this really makes sense, but why keep someone from using it?
• Removing trailing whitespace • Adjusting indention for better readability • Removing duplicated entries
Instead of changing SDEXTRASLOW variable to a slower speed, the new SDULTRASLOW is used for rigidbot panel.
K8200: sample config back in sync
Fix crashes when the Z axis is moved via LCD by calling `plan_buffer_line` only when there is enough room in the planner buffer, to avoid endless recursion. A brief description about what went wrong is in #1166
Fix GCode handling of spaces between command letter and first digit
Fix board type for Hephestos: RAMPS 1.4
Fix "M145" output in M503 report
Example configuration for Kossel XL
raise_z_after_probing() was only called if the printer type was set to a DELTA or if the printer had a docking sled for the probe.
twice for a servo based probe.
Temporary workaround for stack overflow
Fix Z_RAISE_AFTER_PROBING for non DELTA printers
Code cleanup in gcode_T
Enable USE_WATCHDOG by default
Remove unused ALARM_PIN from all the Configuration.h's
Fix disable_all_heaters() for MAX6675
Remove unused ALARM_PIN
Fix status LEDs update when reinitializing the display
Correct raise_z_for_servo for Z offsets below the nozzle
I will close this for now and we can continue to discuss this issue in a new topic around M600. Current topics of discussion are:
|
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to test out the "Change Filament" feature, and before it continues the print, it pulls the filament completely back out again.
When I commented out #define AUTO_FILAMENT_CHANGE, it doesn't have this issue.
The issue here I believe is the current position of the extruder is not being restored from the remembered position.
FILE: Configuration_adv.h