Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Makefile to work with Melzi2 boards on arduino-1.6.x #3224

Merged
merged 1 commit into from
May 9, 2016

Conversation

yarda
Copy link
Contributor

@yarda yarda commented Mar 24, 2016

This fixed the 'make'/'make upload' for me (using Arduino 1.6, Melzi board)

  • also by default use ${HOME}/Arduino as install directory which may be more
    sane, especially on linux with arduino packages provided by distributions
  • bump arduino version to 106 (this seems to be useless)
  • program firmware through the USB serial which is more comfortable way how
    to program the firmware
  • use 57600 programing speed by default which seems to be more reliable
    with arduino bootloaders (at least with those shipped with the Melzi2 boards)

Signed-off-by: Jaroslav Škarvada [email protected]

- also by default use ${HOME}/Arduino as install directory which may be more
sane, especially with arduino packages provided by distributions
- bump arduino version to 106 (this seems to be useless)
- program firmware through the USB serial which is more comfortable way how
to program the firmware
- use 57600 programing speed by default which seems to be more reliable
with arduino bootloaders (at least with those shipped with the Melzi2 boards)

Signed-off-by: Jaroslav Škarvada <[email protected]>
@yarda
Copy link
Contributor Author

yarda commented Mar 24, 2016

I would PR it against MarlinDev/dev as suggested earlier, but it seems there is no Makefile there.

@thinkyhead thinkyhead added PR: Improvement T: Development Makefiles, PlatformIO, Python scripts, etc. Needs: Testing Testing is needed for this change labels Mar 24, 2016
@jbrazio
Copy link
Contributor

jbrazio commented Mar 25, 2016

For Ubuntu the arduino-core package seems to still be installed at /usr/share/arduino/, would it be possible to check multiple locations i.e. check first /usr/share/arduino/ then ${HOME}/Arduino then the "user input location" until the exact location is found ?

@yarda
Copy link
Contributor Author

yarda commented Mar 25, 2016

I think (at least on linux) arduino by default supports ${HOME}/Arduino and /usr/share/arduino/. The former is user scope, the latter is system scope. I think for firmware you don't need to install it system wide as root, because you can compile it/modify it and upload it as normal user. I will check it, but having support for both directories in makefile will be probably the best.

@thinkyhead
Copy link
Member

I would like to get this merged, if it passes muster. But we just haven't had enough feedback and testing from users in varied environments yet. I'm not sure how to acquire more testers, but I can at least test it on OS X. This would be the first time I've messed with the Makefile method, so my results may be less than definitive…

@jbrazio
Copy link
Contributor

jbrazio commented Apr 4, 2016

I can test on Linux and Windows 10, Do you have a particular test we should perform ?

@thinkyhead
Copy link
Member

@jbrazio I'm not sure what test to perform other than to try and compile and see what happens. If it requires some configuration in the OS to get it working, but no changes to the Makefile, then we're on the right track. But I suspect we'll probably need to check the environment to see which OS it is, then use one out of a set of Arduino tool paths.

@jbrazio jbrazio added this to the 1.1.0-RC6 milestone Apr 23, 2016
@jbrazio
Copy link
Contributor

jbrazio commented May 8, 2016

@thinkyhead the collateral effects of this PR are so small I would suggest its merge.

@thinkyhead
Copy link
Member

@jbrazio Ok. I would be curious to know whether anyone in the world wants to use Makefile on OS X, has done so, and knows whether this is compatible. We should be doing a thorough build platform check before picking paths.

@thinkyhead thinkyhead merged commit 6f36b7c into MarlinFirmware:RCBugFix May 9, 2016
@jbrazio
Copy link
Contributor

jbrazio commented May 9, 2016

Agreed, we need to evaluate this.

@thinkyhead
Copy link
Member

Well it's merged now, so perhaps someone out there will "evaluate" it for us!

@jbrazio
Copy link
Contributor

jbrazio commented May 9, 2016

IMO our future will be with something like Makefile + IDE.
Makefile could do a better job than our custom travis build method.

@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Testing Testing is needed for this change PR: Improvement T: Development Makefiles, PlatformIO, Python scripts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants