Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print job statistics #3625

Merged
merged 10 commits into from
Apr 29, 2016
Merged

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented Apr 27, 2016

Fixes #1971

This PR introduces Print Statistics, by default they are disabled, to turn them on the user must #define PRINTCOUNTER in Configuration.h.

//
// Print Counter
//
// When enabled Marlin will keep track of some print statistical data such as:
//  - Total print jobs
//  - Total successful print jobs
//  - Total failed print jobs
//  - Total time printing
//
// This information can be viewed by the M78 command.

A sample output of the M78 command:

M78
Print statistics: Total: 3, Finished: 2, Failed: 1, Total print time: 3h 2min
ok

Note: Still pending the update of the example configuration files.

@thinkyhead
Copy link
Member

thinkyhead commented Apr 28, 2016

That's a pretty exemplary PR — and feature. Classy, even.

A documentation note: We haven't written the definitive documentation for Version 1.1.0 yet, so I feel it's ok to have another feature in it, so long as it is disabled by default. Same goes for configuration options (if we can make them simpler). But we are only a week perhaps from release, so nothing too disruptive like a new probe type today!

Don't forget to add a line in the header of Marlin_main.cpp that documents M78 with the others.

@jbrazio
Copy link
Contributor Author

jbrazio commented Apr 28, 2016

Actually I designed this in a way that for the end-user the only configuration option he should access is PRINTCOUNTER, the other two which control the time between tick() and save() cycles shouldn't be user editable thus I have them as constants inside the object. If you feel this should change and give more freedom to the user to define those two flags I can expose them on Configuration.h.

//
// When enabled Marlin will keep track of some print statistical data such as:
// - Total print jobs
// - Total successfull print jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"successful"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed with e34f465.

@thinkyhead
Copy link
Member

I don't see the need for any major changes or to make it extra configurable.

@jbrazio jbrazio modified the milestone: 1.1.0 (Gold) Apr 29, 2016
@jbrazio jbrazio force-pushed the feature/print-counter branch from 9bc0be7 to e34f465 Compare April 29, 2016 22:14
@jbrazio
Copy link
Contributor Author

jbrazio commented Apr 29, 2016

@thinkyhead it should be ready to be merged now.

@thinkyhead thinkyhead merged commit c3ef999 into MarlinFirmware:RCBugFix Apr 29, 2016
nomukaiki pushed a commit to nomukaiki/Marlin that referenced this pull request May 4, 2016
Some clean-up for example configuration files

Follow-up and fix the PR MarlinFirmware#3253(Make the Autotune item(s) in the LCD menu optional):
・Update forgotten file(Felix/Configuration_DUAL.h)

Follow-up the PR MarlinFirmware#3526(Configuration.h LCD & SDCard section rewrite):
・Add section of RigidBot Panel to RepRapWorld/Megatronics/Configuration.h

Follow-up the PR MarlinFirmware#3576(Z Safe Homing for all):
・Adjust spacing

Follow-up and fix the PR MarlinFirmware#3625(Print job statistics):
・Update forgotten file(Felix/Configuration_DUAL.h)
・Remove ambiguous character "f" in top of RigidBot/Configuration.h
@jbrazio jbrazio deleted the feature/print-counter branch May 10, 2016 00:43
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
CONSULitAS pushed a commit to CONSULitAS/Marlin-K8200 that referenced this pull request Aug 18, 2016
Some clean-up for example configuration files

Follow-up and fix the PR MarlinFirmware#3253(Make the Autotune item(s) in the LCD menu optional):
・Update forgotten file(Felix/Configuration_DUAL.h)

Follow-up the PR MarlinFirmware#3526(Configuration.h LCD & SDCard section rewrite):
・Add section of RigidBot Panel to RepRapWorld/Megatronics/Configuration.h

Follow-up the PR MarlinFirmware#3576(Z Safe Homing for all):
・Adjust spacing

Follow-up and fix the PR MarlinFirmware#3625(Print job statistics):
・Update forgotten file(Felix/Configuration_DUAL.h)
・Remove ambiguous character "f" in top of RigidBot/Configuration.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants