-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print job statistics #3625
Print job statistics #3625
Conversation
That's a pretty exemplary PR — and feature. Classy, even. A documentation note: We haven't written the definitive documentation for Version 1.1.0 yet, so I feel it's ok to have another feature in it, so long as it is disabled by default. Same goes for configuration options (if we can make them simpler). But we are only a week perhaps from release, so nothing too disruptive like a new probe type today! Don't forget to add a line in the header of |
Actually I designed this in a way that for the end-user the only configuration option he should access is |
// | ||
// When enabled Marlin will keep track of some print statistical data such as: | ||
// - Total print jobs | ||
// - Total successfull print jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"successful"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixed with e34f465.
I don't see the need for any major changes or to make it extra configurable. |
9bc0be7
to
e34f465
Compare
@thinkyhead it should be ready to be merged now. |
Some clean-up for example configuration files Follow-up and fix the PR MarlinFirmware#3253(Make the Autotune item(s) in the LCD menu optional): ・Update forgotten file(Felix/Configuration_DUAL.h) Follow-up the PR MarlinFirmware#3526(Configuration.h LCD & SDCard section rewrite): ・Add section of RigidBot Panel to RepRapWorld/Megatronics/Configuration.h Follow-up the PR MarlinFirmware#3576(Z Safe Homing for all): ・Adjust spacing Follow-up and fix the PR MarlinFirmware#3625(Print job statistics): ・Update forgotten file(Felix/Configuration_DUAL.h) ・Remove ambiguous character "f" in top of RigidBot/Configuration.h
Some clean-up for example configuration files Follow-up and fix the PR MarlinFirmware#3253(Make the Autotune item(s) in the LCD menu optional): ・Update forgotten file(Felix/Configuration_DUAL.h) Follow-up the PR MarlinFirmware#3526(Configuration.h LCD & SDCard section rewrite): ・Add section of RigidBot Panel to RepRapWorld/Megatronics/Configuration.h Follow-up the PR MarlinFirmware#3576(Z Safe Homing for all): ・Adjust spacing Follow-up and fix the PR MarlinFirmware#3625(Print job statistics): ・Update forgotten file(Felix/Configuration_DUAL.h) ・Remove ambiguous character "f" in top of RigidBot/Configuration.h
Fixes #1971
This PR introduces Print Statistics, by default they are disabled, to turn them on the user must
#define PRINTCOUNTER
inConfiguration.h
.A sample output of the M78 command:
Note: Still pending the update of the example configuration files.