Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need to define unused pins as -1 in pins files #3702

Merged

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented May 8, 2016

This is a cleanup that is both obvious and long overdue.

Background: Pins files are "littered" with definitions of pins they don't have, and #undef lines only needed due to certain choices in pins.h.

This PR removes instances in pins files where:

  • Pins are defined as -1 (when they are not overrides of RAMPS pins, for example)
  • Adds conditional defines to pins.h defining pins not defined by the board.
  • Removes the pre-defined pins from the top of pins.h that required board-pins to #undef them.

This PR additionally:

  • Adds microstepping and extruder auto fans to the sensitive pins list
  • Adds FAN1 and FAN2 to the sensitive pins list
  • Moves the conditional definition of analogInputToDigitalPin to pins.h
  • Alters analogInputToDigitalPin to account for -1 (don't convert it into 0x9F!)

@thinkyhead thinkyhead force-pushed the rc_sensitive_fan_pins branch from 6df9a63 to 5ca6334 Compare May 8, 2016 19:38
@thinkyhead thinkyhead merged commit 1b90682 into MarlinFirmware:RCBugFix May 14, 2016
@thinkyhead thinkyhead deleted the rc_sensitive_fan_pins branch May 14, 2016 22:49
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
…_fan

PFW-1415: Rename `Extruder fan` to `Hotend fan` MK3_3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants