Remove need to define unused pins as -1 in pins files #3702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup that is both obvious and long overdue.
Background: Pins files are "littered" with definitions of pins they don't have, and
#undef
lines only needed due to certain choices inpins.h
.This PR removes instances in pins files where:
pins.h
defining pins not defined by the board.pins.h
that required board-pins to#undef
them.This PR additionally:
analogInputToDigitalPin
topins.h
analogInputToDigitalPin
to account for-1
(don't convert it into0x9F
!)