Removes the DISABLE from HOST_KEEPALIVE #3720
Conversation
|
I think you meant "and it's now active by default…." |
|
|
|
Ok makes sense, will fix it as soon as I stop commuting and get a wifi connection. |
|
As far i remember we wanted to avoid as a default in the configurations and want to use instead where ever possible. Did that change? |
|
@Blue-Marlin Why ? Does it make sense to complicate something by enabling the negative option to disable the option ? We're talking about pre-processor stuff it will not take more or less bytes on the binary file. |
|
If there is still the idea around to have a user-pre- or post-configuration, what is basically a diff to the standard-configuration, every defined-by-default item needs a special handling. Ether a Is this still a design target? |
|
My answer is "meh".. the over engineered config handler we have on MarlinDev is dead, this seems to be settled upon. But I never saw any discussion discarding [or approving] pre/post config files. |
jbrazio
force-pushed
the
feature/host-keepalive
branch
from
c8ec6d3 to
85b2c80
Compare
|
@thinkyhead rebased. |
| #define DEFAULT_KEEPALIVE_INTERVAL 2 // Number of seconds between "busy" messages. Set with M113. | ||
| #endif | ||
| #define HOST_KEEPALIVE_FEATURE // Disable this if your host doesn't like keepalive messages | ||
| #define DEFAULT_KEEPALIVE_INTERVAL 2 // Number of seconds between "busy" messages. Set with M113. |
There was a problem hiding this comment.
I always group sub-options with the main option that they depend on. Because my configurator tool picks up on this and uses it to "grey out" the option until the main option is enabled.
#if ENABLED(HOST_KEEPALIVE_FEATURE)
#define DEFAULT_KEEPALIVE_INTERVAL 2 // Number of seconds between "busy" messages. Set with M113.
#endif
ghost
mentioned this pull request
* RCBugFix: (64 commits) Automatically set X2 stepper pins Add Travis test for DUAL_X_CARRIAGE Implements S1 argument in M999 Improve DUAL_X_CARRIAGE sanity check errors Declare extruder_duplication_enabled in Marlin.h Update Japanese trasration Function decl. in headers don't need "extern" Bezier style and DELTA patch XYZ unhomed Require homing of Z before G29 Minor DELTA segmentation speedup G29: Report final position back to host when using MBL Add stowing process for MECHANICAL_PROBE Separate Z_PROBE_ALLEN_KEY from MECHANICAL_PROBE Fix checkExtruderAutoFans Bugfix: iteration invokes undefined behavior Fix MBL zigzag calls Follow-up the PR MarlinFirmware#3720 and MarlinFirmware#3759 Remove the hotbed icon when HAS_TEMP_BED is false Prevent watchdog timeout in bezier moves ... # Conflicts: # Marlin/pins_RAMPS_14.h
Update forgotten Configuration_DUAL.h
…odel_menu MK3_3.12: Add Menu Calibration -> Temp Model cal.
In order to harmonize
HOST_KEEPALIVEwith most of the otherConfiguration.hdirectives,DISABLE_HOST_KEEPALIVEwas renamed toHOST_KEEPALIVE_FEATUREand it's now active by default on all configuration files.No behavior change, just less twisting user's mind.