Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual Axis Homing LCD menu items #3740

Merged
merged 1 commit into from
May 12, 2016
Merged

Individual Axis Homing LCD menu items #3740

merged 1 commit into from
May 12, 2016

Conversation

thinkyhead
Copy link
Member

Squashed version of #3718.

@thinkyhead thinkyhead force-pushed the rc_lcd_home_options branch from f702782 to 3b8bf24 Compare May 12, 2016 01:32
Blue-Marlin
Blue-Marlin reviewed May 12, 2016
View reviewed changes
Marlin/example_configurations/RigidBot/Configuration.h
// Add individual axis homing items (Home X, Home Y, and Home Z) to the LCD menu.
//
//#define INDIVIDUAL_AXIS_HOMING_MENU

//===========================================================================
//============================= Getting Started =============================
//===========================================================================
Copy link
Contributor

@Blue-Marlin Blue-Marlin May 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above Getting Started ???

@thinkyhead thinkyhead force-pushed the rc_lcd_home_options branch from 3b8bf24 to 09150ca Compare May 12, 2016 02:28
@jbrazio jbrazio added this to the 1.1.0 milestone May 12, 2016
@thinkyhead thinkyhead merged commit 14cd0f4 into MarlinFirmware:RCBugFix May 12, 2016
@thinkyhead thinkyhead deleted the rc_lcd_home_options branch May 12, 2016 18:59
@ghost
Copy link

ghost commented May 13, 2016 •
edited by ghost
Loading

I think that this menu items had been better hide with delta machine.
Because in case of delta, it seems that G28 X, G28 Y, and G29 Z are synonymous with G28.

But, I can't decide which is better that it should be caused error by SanityCheck or it should be hidden by inserting #if DISABLED(DELTA) derective into ultralcd.cpp.

@jbrazio
Copy link
Contributor

jbrazio commented May 13, 2016

As this menu items are only shown if the user activates them I would say the best place is with SanityCheck.h and document there why with a delta individual axis homing does not work.

@jbrazio jbrazio mentioned this pull request May 14, 2016
Merged
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: New Feature
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkyhead @jbrazio @Blue-Marlin