Enclose all #error strings by double-quotes #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As stated here this is a good practice. |
|
I have enclosed all #error strings that contain an apostrophe in double-quotes. Otherwise they are not needed, so they have been left out. In my opinion, this is being overly pedantic. |
ghost
changed the title
|
I'm sorry, I mistook title of this PR completely because of my mad English... And, it seems that development team of Marlin doesn't reach an agreement on this suggestion. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: PR #3706(Enclose #error strings with apostrophes in quotes)
This PR isn't so much request as suggestion.
I think that it's better that form(coding style?) of
#erroris standardized.