Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set X2 stepper pins #3779

Merged
merged 1 commit into from
May 19, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented May 17, 2016

Background: For DUAL_X_CARRIAGE the X2 pins can be automatically set to the first unused Extruder stepper pins, so that's what this PR does (if the X2 pins are not already set in the configuration).

Since it's possible to combine Y_DUAL_STEPPER_DRIVERS or Z_DUAL_STEPPER_DRIVERS with a DUAL_X_CARRIAGE on a board with enough free stepper drivers, this PR moves those stepper pins to the next available E plug when DUAL_X_CARRIAGE is enabled.

The automated results end up as:

Configuration Steppers Order
Normal X, Y, Z, E0
Dual Extruder X, Y, Z, E0, E1
Dual X Carriage X, Y, Z, E0, E1, X2
Dual Y Steppers X, Y, Z, E0, Y2
Dual Z Steppers X, Y, Z, E0, Z2
Dual X Carriage + Dual Y Steppers X, Y, Z, E0, E1, X2, Y2
Dual X Carriage + Dual Z Steppers X, Y, Z, E0, E1, X2, Z2
  • This PR also removes the default/example overrides for the X2 stepper pins from Configuration_adv.h.

@thinkyhead thinkyhead added PR: Improvement Needs: More Data We need more data in order to proceed labels May 17, 2016
@thinkyhead thinkyhead force-pushed the rc_x2_automatic_pins branch 8 times, most recently from 785efd3 to 4f6be6f Compare May 19, 2016 00:39
@thinkyhead thinkyhead removed the Needs: More Data We need more data in order to proceed label May 19, 2016
@thinkyhead thinkyhead force-pushed the rc_x2_automatic_pins branch from 4f6be6f to 07c9a11 Compare May 19, 2016 02:09
@thinkyhead thinkyhead merged commit b422e39 into MarlinFirmware:RCBugFix May 19, 2016
@thinkyhead thinkyhead deleted the rc_x2_automatic_pins branch May 19, 2016 02:27
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
@nivekhan
Copy link

In the case that Dual X, Dual Y, AND Dual Z are implemented, would it make sense to add in pins.h
#define Y2_Z2_E_INDEX INCREMENT(EXTRUDERS)
(line 357) right after line 368 so that the order goes X,Y,Z,E0,E1,X2,Y2,Z2?

@thinkyhead
Copy link
Member Author

@caenan0 Funny you should mention that…. #4271

@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
…ad_mmu

Don't show full screen message meant for single color setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants