Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL: Add option to configure G28 resting position for all axes #3802

Merged
merged 4 commits into from
May 20, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented May 20, 2016

Supplants #3793, adding the new option to the rest of the configurations.

  • Adds Travis CI test for MBL

@epatel
Copy link
Contributor

epatel commented May 20, 2016

You moved the "rest" word so it breaks the intended meaning. "'G28' all axis" is the requirement for it to apply this thing, the move is not applied if not homing all axises. I wanted to be specific about that.

@thinkyhead
Copy link
Member Author

thinkyhead commented May 20, 2016

Thank you for clarifying that! It's always a little hard to infer the intention of non-native English speakers. I will make the correction forthwith!

@thinkyhead thinkyhead force-pushed the rc_epatel_g28_rest_pos branch from 247c13d to f69b5af Compare May 20, 2016 18:52
@thinkyhead
Copy link
Member Author

This should make sense translated into most languages…

// After homing all axes ('G28' or 'G28 XYZ') rest at origin [0,0,0]

@thinkyhead thinkyhead merged commit 88291d1 into MarlinFirmware:RCBugFix May 20, 2016
@thinkyhead thinkyhead deleted the rc_epatel_g28_rest_pos branch May 20, 2016 19:10
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants