Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SINGLENOZZLE: EXTRUDERS versus HOTENDS #3895

Merged

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented May 27, 2016

Background: With SINGLENOZZLE (and perhaps future features) we need to separate the number of EXTRUDERS from the number of heaters-fan-thermistor combos, aka HOTENDS. Currently the SINGLENOZZLE implementation is incomplete, because it won't handle the temperature aspects correctly.

Solution: This PR follows up the previous SINGLENOZZLE feature PR, taking into account that only one heater-fan-thermistor combo exists for the multi-extruder. Where needed, the EXTRUDERS count is replaced with a HOTENDS count. When using SINGLENOZZLE the HOTENDS count will always be 1. Otherwise it will be equal to EXTRUDERS.

  • Rename EXTRUDER_OFFSET_[XY] to HOTEND_OFFSET_[XY]
  • Rename EXTRUDER_WATTS to HOTEND_WATTS
  • Rename PID_PARAMS_PER_EXTRUDER to PID_PARAMS_PER_HOTEND
  • Rename extruder_offset to hotend_offset
  • Add sanity checks for renamed options
  • Separate definition/setting/handling of extruder pins from heater-fan-sensor pins
  • Modify temperature methods for SINGLENOZZLE (ignore the extruder index)

References:

@thinkyhead thinkyhead force-pushed the rc_singlenozzle_part_2 branch 4 times, most recently from 0a38ec5 to c181698 Compare May 27, 2016 01:55
@jbrazio jbrazio added this to the 1.1.0 milestone May 30, 2016
@thinkyhead thinkyhead force-pushed the rc_singlenozzle_part_2 branch 5 times, most recently from bbc9d09 to f1e1484 Compare June 4, 2016 00:11
@thinkyhead thinkyhead force-pushed the rc_singlenozzle_part_2 branch from f1e1484 to f2fb66c Compare June 4, 2016 00:38
@thinkyhead thinkyhead merged commit 4394707 into MarlinFirmware:RCBugFix Jun 4, 2016
@thinkyhead thinkyhead deleted the rc_singlenozzle_part_2 branch June 4, 2016 22:23
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants