set_current_position_from_planner() after stepper.quick_stop() #3939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: The
stepper.quick_stop()
method (used byM410
and the "Stop print" menu item) throws away all buffered planner moves. This causes the planner / stepper positions to become out-of-sync with thecurrent_position
.Solution: After
stepper.quick_stop()
call a new functionset_current_position_from_planner()
which:current_position
based on the stepper positions, andplanner.position
from the newcurrent_position
.References: #3899, #3545 (comment)