Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved LCD contrast handling #3944

Merged
merged 3 commits into from
Jun 4, 2016
Merged

Improved LCD contrast handling #3944

merged 3 commits into from
Jun 4, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jun 2, 2016 •
edited
Loading

Based on MarlinFirmware/MarlinDev#200 from @eboston

  • Rename lcd_setcontrast to set_lcd_contrast
  • Add LCD_CONTRAST_(MIN|MAX) defines, default 0-63
  • Constrain LCD contrast to min/max wherever it is set (by set_lcd_contrast)
  • Include a contrast range for miniVIKI (for completeness)
  • Use positive conditions for HAS_LCD_CONTRAST
  • Add a sanity check for mutually-exclusive SAV_3DGLCD display options

References: #751 (comment), #3912 (comment)

@thinkyhead thinkyhead mentioned this pull request Jun 2, 2016
Merged
@thinkyhead thinkyhead force-pushed the rc_eboston_lcd_contrast branch 2 times, most recently from b019eba to fbabd56 Compare June 2, 2016 22:26
@thinkyhead thinkyhead force-pushed the rc_eboston_lcd_contrast branch from fbabd56 to 5390c84 Compare June 2, 2016 23:17
@thinkyhead thinkyhead merged commit 32f8300 into MarlinFirmware:RCBugFix Jun 4, 2016
@thinkyhead thinkyhead mentioned this pull request Jun 4, 2016
Closed
@thinkyhead thinkyhead deleted the rc_eboston_lcd_contrast branch June 4, 2016 00:10
@jbrazio jbrazio added this to the 1.1.0 milestone Jun 7, 2016
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix PR: Improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @jbrazio