Heal the watchdog #4012
Merged
Heal the watchdog #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #if ENABLED(USE_WATCHDOG) | ||
| watchdog_reset(); | ||
| #endif | ||
| thermalManager.manage_heater(); |
There was a problem hiding this comment.
This will not work.. why ?
Because our buzzer will need to depend on the thermal like I said before.
|
Travis said it.. $ build_marlin
Picked up JAVA_TOOL_OPTIONS:
Loading configuration...
Xlib: extension "RANDR" missing on display ":1.0".
Initializing packages...
Preparing boards...
Verifying...
In file included from sketch/Marlin.h:382:0,
from sketch/M100_Free_Mem_Chk.cpp:43:
sketch/buzzer.h: In member function 'void Buzzer::tone(const uint16_t&, const uint16_t&)':
buzzer.h:109: error: 'thermalManager' was not declared in this scope
thermalManager.manage_heater();
^
exit status 1
'thermalManager' was not declared in this scope |
Blue-Marlin
force-pushed
the
watchdoghealing
branch
from
e4e1abc to
d083c44
Compare
Blue-Marlin
force-pushed
the
watchdoghealing
branch
from
d083c44 to
efe719f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heal the watchdog by replacing the unnecessary call to
watchdog_reset()bythermalManager.manage_heater()See discussion in 'New feature: Non blocking tone queue #3995'