Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of M48 #4081

Merged
merged 5 commits into from
Jun 19, 2016
Merged

Cleanup of M48 #4081

merged 5 commits into from
Jun 19, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jun 18, 2016 •
edited
Loading

  • Declare autos in M48 on first use with ternary expressions
  • Shrink debug code in G28
  • Shrink probe_pt code in M48
  • Use only needed stack space for the sample_set array in M48

@thinkyhead thinkyhead force-pushed the rc_tweaky_m48_tweaks branch 4 times, most recently from e93f331 to 0cf32fb Compare June 18, 2016 10:54
@thinkyhead thinkyhead force-pushed the rc_tweaky_m48_tweaks branch from 0cf32fb to 80b8158 Compare June 18, 2016 22:38
@thinkyhead
Copy link
Member Author

@Roxy-3D As I've been simplifying the probing code it's making more sense and becoming easier to follow, and I've been able to clean up gcode_M48 a little based on new insights. So please give this PR a test and make sure that M48 (both with and without E) is behaving as it should.

@thinkyhead thinkyhead force-pushed the rc_tweaky_m48_tweaks branch from 80b8158 to b7e3c1b Compare June 18, 2016 23:18
@thinkyhead thinkyhead changed the title Just-in-time declaration style in M48 Cleanup of M48 Jun 18, 2016
@Roxy-3D
Copy link
Member

Roxy-3D commented Jun 19, 2016

So please give this PR a test and make sure that M48 (both with and without E) is behaving as it should.

Will do. I just sent you a message in the Google Chat window about a problem I'm having and my planned path forward. Unless there is a reason why I should change paths, I'm going to do a 3-Way merge of my code to the current RCBugfix.

I know this isn't standard procedure, but I'm going to merge your M48 changes now. As soon as I get my 3-Way Merge done the first thing I'll do is give M48 a full test suite. If there are any problems that show up (Probably not! I have faith in you!), I'll have the debugged lines of code for you by early next week. Do I need to check out Delta's too?

@Roxy-3D Roxy-3D merged commit 96b8bcc into MarlinFirmware:RCBugFix Jun 19, 2016
@thinkyhead thinkyhead deleted the rc_tweaky_m48_tweaks branch June 19, 2016 04:37
@thinkyhead
Copy link
Member Author

It wouldn't hurt to check out deltas, since it has a different way of doing the "legs" part.

@Roxy-3D
Copy link
Member

Roxy-3D commented Jun 19, 2016

OK... Will do... I'll get the Cartesian's checked out first.

@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Coding Standards
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkyhead @Roxy-3D @jbrazio