Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FILAMENT_RUNOUT_SENSOR, FILRUNOUT_PIN #4095

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Improve FILAMENT_RUNOUT_SENSOR, FILRUNOUT_PIN #4095

merged 1 commit into from
Jun 20, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jun 20, 2016 •
edited
Loading

  • Always define FILRUNOUT_PIN for those boards that assign one.
  • Make code dependent on FILAMENT_RUNOUT_SENSOR instead of the pin.
  • Sanity check for the pin and for SDSUPPORT if this feature is enabled.

@thinkyhead thinkyhead force-pushed the rc_fil_runout_cleanup branch 3 times, most recently from ffdaf75 to fc8adba Compare June 20, 2016 01:12
@thinkyhead thinkyhead force-pushed the rc_fil_runout_cleanup branch from fc8adba to add0032 Compare June 20, 2016 01:13
@thinkyhead thinkyhead merged commit 7b5cd31 into MarlinFirmware:RCBugFix Jun 20, 2016
@thinkyhead thinkyhead deleted the rc_fil_runout_cleanup branch June 20, 2016 01:48
@thinkyhead thinkyhead mentioned this pull request Jun 20, 2016
Closed
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Coding Standards PR: General Cleanup
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @jbrazio