-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deploy/stow with FIX_MOUNTED_PROBE too #4100
Conversation
Always raise Z (if needed) for servo deploy/stow
Hello Scott.
it is not best to do so?
|
Perhaps. But the result here will be the same. If the compiler sees |
I admit my ignorance, but I thought I compile the same code by adding useless. How not say sorry .. |
f8640ad
to
e93b687
Compare
The current code will throw an error if any of these allen key macros are undefined. Using preprocessor macros, we need to do a little more work, because undefined macros are evaluated as zero. So really, you would need: #if defined(Z_PROBE_ALLEN_KEY_STOW_2_X) && defined(Z_PROBE_ALLEN_KEY_STOW_1_X) \
&& Z_PROBE_ALLEN_KEY_STOW_2_X != Z_PROBE_ALLEN_KEY_STOW_1_X
destination[X_AXIS] = Z_PROBE_ALLEN_KEY_STOW_2_X;
#endif |
bcb5ee0
to
915b96e
Compare
Follow up #4096
deploy_z_probe
andstow_z_probe
even without ABL