Allow stopwatch and printcounter to go over 18:12:15

[thinkyhead]

Addressing #4195

After 18 hours, 12 minutes, and 16 seconds, a 16-bit integer counting seconds will overflow. This PR alters variables in stopwatch and printcounter to use millis_t instead of 16-bit integers.

• Use wider integers to store time durations
• Extend M31 to include days in its output
• Run M31 at the end of an SD print rather than custom-printing the time

[thinkyhead]

@MarlinFirmware/host-software-team
Do hosts expect the output of M31 to never include hours (only min and sec)?

[foosel]

Stock OctoPrint doesn't even parse M31 output, so wouldn't be affected by any changes there. Don't know about other hosts though.

[petrzjunior]

@thinkyhead Oh, good idea to prevent overflow! I was trying to do exactly the same yesterday, but I wasn't successful enough to push it.

I'm not sure, what millis_t is, but I was thinking about uint32_t. This would extend it to 4 billion second, roughly 50 000 days. I was also trying to reformat the info menu to show the timer on new line as "_days_d _hours_h _minutes_m", this would with 50 thousand days fit perfectly even into 14 chars on LCD.

But strange things happened and this snippet

sprintf(printTime, "%02ud %02uh %02um", 
        (uint16_t)(stats.printTime / 86400), 
        ((uint32_t)(stats.printTime / 60)) % 60, 
        ((uint32_t)(stats.printTime / 3600)) % 24
);

doesn't work on Arduino while in online C++ Shell does.
It skips the middle (sometimes the last) value while formatting. Strange. Blindness or Arduino bug?

I would certainly implement days, since @clexpert's printer is printing more than someone would expect. 😄

[thinkyhead]

I'm not sure, what millis_t is…

A search of the source code reveals…

typedef unsigned long millis_t;

strange things happened and this snippet

I would suggest instead…

sprintf(printTime, "%id %02ih %02im", 
        int(stats.printTime / 60 / 60 / 24),
        int(stats.printTime / 60 / 60) % 60,
        int(stats.printTime / 60) % 60
);

[ghost]

It seems that MSG_INFO_PRINT_COUNT is right.

[ghost]

Excuse me I've a question, are MSG_END_DAY, MSG_END_HOUR, and MSG_END_MINUTE used where?

[jbrazio]

I can't find their usage anywhere in the code (current RCBugfix).. maybe on a unmerged PR ?

[Blue-Marlin]

Yesterday removed with 34da77d

[thinkyhead]

Hmm, guess those strings are now obsolete. Print time on the display is now coming from M31.

[ghost]

I see, thus I'll remove those from language files that I'm managing.

[kakaroto]

a bit late here, but just to confirm that Cura LE also doesn't use M31 and counts the print time internally (and stops/resumes the counter when user pauses/resumes the print).