-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing translations (Italian) #4300
Conversation
#if LCD_WIDTH > 19 | ||
#define MSG_INFO_PRINT_COUNT "Contat. stampa" | ||
#define MSG_INFO_FINISHED_PRINTS "Finiti " | ||
#define MSG_INFO_PRINT_TIME "Tempo totale" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 strings are meant to align. Please add a trailing space to each of the two the shorter strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thinkyhead Please check if it is ok now.
Why have you closed this pull request? There is some errors in my PR? |
@tnw513 look at #4329, it was a rebase of this one so it could be merged. |
I see, but why an other PR? I've made a mistake? |
"Rebase" must be done in the command line git and basically means that you want to update your working tree to the latest RCBugfix (the base) and then re-apply your changes on top of it. If you look at the #4329 the change credit is still assign to your username, so it's exactly the same thing as merging this one but some times we cannot automatically merge changes using the Github web interface due to conflicts. We could ask the person to rebase the PR or in this case we do it ourselves. |
Ok, perfect. No problem for credit, it's only a translation :) |
Just to make it all clear. :-D |
No change in memory
No description provided.