-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOZZLE_CLEAN_FEATURE with no dependency on HAS_BED_PROBE #4354
NOZZLE_CLEAN_FEATURE with no dependency on HAS_BED_PROBE #4354
Conversation
5e5a684
to
0dfc589
Compare
0dfc589
to
0149fc1
Compare
After merging of this PR, I got much compilation warnings.
|
/**
* Blocking movement and shorthand functions
*/
static void do_blocking_move_to(float x, float y, float z, float fr_mm_m=0.0);
static void do_blocking_move_to_axis_pos(AxisEnum axis, float where, float fr_mm_m=0.0);
static void do_blocking_move_to_x(float x, float fr_mm_m=0.0);
static void do_blocking_move_to_y(float y);
static void do_blocking_move_to_z(float z, float fr_mm_m=0.0);
static void do_blocking_move_to_xy(float x, float y, float fr_mm_m=0.0); Declaring something as static on a header file will make the compiler complain because it expects for each src file including that header file to define it's own version of the static function. @esenapaj as these changes were done by @thinkyhead I will let him take the lead what do to here. My suggestion would be to inline them as they were on the initial PR but that can be expensive #4348 (comment).. |
I see. If possibly this change is causing chaotic homing and probing, and if it could be solved by fixing this, I'm(we're?) happy... |
When I change those Edit: It looks like that something in my comment is makeing you uncomfortable?, sorry... |
I found that the build size went down when I added |
Here are the odd build sizes I refer to…
|
Rebase of #4348