Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always switch to tool 0 for G28 #4360

Merged
merged 2 commits into from
Jul 21, 2016
Merged

Always switch to tool 0 for G28 #4360

merged 2 commits into from
Jul 21, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jul 20, 2016 •
edited
Loading

Homing with other tools selected is problematic. This proposed solution does a tool-change back to T0 at the start of G28 and restores the original tool at the end of G28.

  • Add a tool_change(tool, fr, no_move) function
  • Call tool_change as needed from G28 and gcode_T
  • Modify gcode_T so it just does setup and calls tool_change

References: #4266, #4347

@thinkyhead thinkyhead mentioned this pull request Jul 20, 2016
Closed
@jbrazio jbrazio added this to the 1.1.0 milestone Jul 20, 2016
@thinkyhead thinkyhead force-pushed the rc_toolchange_for_G28 branch from 38d2911 to f76aed1 Compare July 20, 2016 16:32
@thinkyhead thinkyhead force-pushed the rc_toolchange_for_G28 branch from f76aed1 to 62ecd10 Compare July 20, 2016 16:37
@thinkyhead thinkyhead merged commit 16e5348 into MarlinFirmware:RCBugFix Jul 21, 2016
@thinkyhead thinkyhead deleted the rc_toolchange_for_G28 branch July 21, 2016 02:07
@oysteinkrog
Copy link
Contributor

👍

@thinkyhead thinkyhead mentioned this pull request Jul 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug: Confirmed ! PR: Bug Fix
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkyhead @oysteinkrog @jbrazio