Fix, cleanup DELTA G28 / G29 support functions #4373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #4361 (comment)
Recent changes to probing and movement functions missed some nuances, such as:
current_position
ahead of calling movement functions except those that specifically move to thecurrent_position
because some of them want to compare the destination tocurrent_position
.)destination
fromcurrent_position
after a call toprepare_move_to_destination*
because they always callset_current_to_destination
.This PR patches these bugs and removes other superstitious redundancies in setting
current_position
anddestination
.